Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new partial pattern to help queries #905

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add new partial pattern to help queries #905

wants to merge 2 commits into from

Conversation

rays22
Copy link
Contributor

@rays22 rays22 commented Mar 2, 2023

If applied, this commit will fix #904.

If applied, this commit will fix #904.
@rays22 rays22 requested review from matentzn and sbello March 2, 2023 16:59
@rays22 rays22 self-assigned this Mar 2, 2023
@sbello
Copy link

sbello commented Mar 2, 2023

@matentzn I don't think we wanted this to be a term creation pattern, correct? I thought what you wanted was to capture the standard for adding subclass axioms to existing terms to enrich the anatomy cross-references in the ontology. I don't think this should follow the standard set up for a UPheno pattern.
Anna and I discussed this with @rays22 at today's meeting

@matentzn
Copy link
Collaborator

matentzn commented Mar 3, 2023

I think its great to have this as a pattern - remember patterns are not only to "create new terms", but also to capture/document certain modelling decisions. I have some feedback on the PR, but it is definitely good to have these as a pattern.

@sbello
Copy link

sbello commented Mar 3, 2023

@matentzn I wasn't suggesting we not have the pattern but just questioning the need to have the term creating parts like name, definition, synonyms in the pattern. Having these here suggests that this pattern could be used to generate a new term and that is not the purpose in this case.

@matentzn
Copy link
Collaborator

matentzn commented Mar 3, 2023

You are 100% correct on that @sbello - sorry, misunderstood you. @rays22 we only need the subclass axiom template from the generative features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create a pattern for adding anatomy subclass axioms
3 participants