An easier one shot subscribe API #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
obmarg
changed the title
obmarg
force-pushed
the
obmarg/push-luxrywlwzpqk
branch
from
4514442
to
587c1b4
Compare
obmarg
commented
Feb 9, 2024
obmarg
force-pushed
the
obmarg/push-luxrywlwzpqk
branch
from
71117c5
to
568f95b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphql-ws-clientwas designed to allow multiple subscriptions to be run on a single connection. This is still something I want to support, but it's also common for users to only want to run a single subscription per connection. Right now the API for doing that is a bit too verbose.This PR will introduce a
streaming_operationfunction on theClientBuilderto handle this use case, combining the connect, subscribe and actor spawning into a single function call.Todo: