Remove GraphqlClient trait
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working with
graphql-ws-clientrecently and I'm not that happy with it's API. This is the first in a series of refactors to simplify it a bunch.First on the chopping block: the
GraphqlClienttrait. There wasn't a ton of point to this - it lets client implementations avoid temporarily deserializing errors intoserde_json::Valuebut generally the response data still has to go through this. I suppose it'd also let clients use something other thanserde_jsonbut in practice I'm not sure how useful this is.Removing this simplifies the API a bunch, so I think it's worthwhile.