Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the implementation a bit #57

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Simplify the implementation a bit #57

merged 4 commits into from
Jan 19, 2024

Conversation

obmarg
Copy link
Owner

@obmarg obmarg commented Jan 19, 2024

  • Removed the sender_loop function, replaced it with StreamExt::forward
  • Noticed the GraphqlClient generic parameter on SubscriptionStream wasn't doing anything so got rid of it.
  • Switched the subscription IDs to be integers so I could remove the uuid dependency. It didn't seem worth the extra compile time for that one feature.

@obmarg obmarg merged commit 625054c into main Jan 19, 2024
2 checks passed
@obmarg obmarg deleted the obmarg/push-mxzzwxmztsuw branch January 19, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant