Enum support in C/C++ #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenrobot
reviewed
Aug 27, 2021
| @@ -25,87 +25,96 @@ static inline OBX_model* create_obx_model() { | |||
|
|
|||
| obx_model_entity(model, "Typeful", 1, 8717895732742165505); | |||
| obx_model_entity_flags(model, (OBXEntityFlags) (OBXEntityFlags_SHARED_GLOBAL_IDS | OBXEntityFlags_SYNC_ENABLED)); | |||
| obx_model_property(model, "id", OBXPropertyType_Long, 1, 3390393562759376202); | |||
| obx_model_property(model, "id", OBXPropertyType_Long, 1, 2669985732393126063); | |||
There was a problem hiding this comment.
This is already a larger PR to review; could you please keep the existing ID with reasonable effort?
There was a problem hiding this comment.
I've tried moving to another .fbs but it doesn't help - still ends up with new IDs because these files are always regenerated. The only option is adding another "directory" to the comparison test (i.e. it wouldn't be in typeful but enums) but you didn't want that previously.
BTW the first commit is just adding the enum to the model. the second commit is the actual changes - maybe ignoring the first commit helps reviewing
greenrobot
reviewed
Aug 27, 2021
test/comparison/testdata/fbs/typeful/cpp/schema.obx.cpp.expected
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #33