Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue: Intermittent UI exception while opening the Import Virtual Machine(s) pop-up #925

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue: Intermittent UI exception while opening the Import Virtual Machine(s) pop-up #925

wants to merge 1 commit into from

Conversation

shubhaOracle
Copy link
Contributor

@shubhaOracle shubhaOracle commented Feb 29, 2024 •
edited
Loading

Signed-off-by: ShubhaOracle [email protected]

Fixes issue

Intermittent UI exception while opening the Import Virtual Machine(s) pop-up

Stack Trace when error happens:

2023-07-17 11:11:12,436-06 ERROR [org.ovirt.engine.ui.frontend.server.gwt.OvirtRemoteLoggingService] (default task-43) [] Uncaught exception: com.google.gwt.core.client.JavaScriptException: (TypeError) : a is null
at java.math.Conversion.toDecimalScaledString(Conversion.java:175)
at org.ovirt.engine.ui.webadmin.section.main.view.popup.storage.RegisterEntityInfoPanel18.18.18.getRawValue(RegisterEntityInfoPanel.java:314)
at org.ovirt.engine.ui.webadmin.section.main.view.popup.storage.RegisterEntityInfoPanel$18.getRawValue(RegisterEntityInfoPanel.java:314)

Changes introduced with this PR

  • Add checks for null values

@shubhaOracle
Copy link
Contributor Author

Requesting Reviews.

dupondje
dupondje suggested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@dupondje dupondje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good to me!

...va/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterEntityInfoPanel.java Outdated Show resolved Hide resolved
@shubhaOracle
Copy link
Contributor Author

Requesting Reviews.

@shubhaOracle shubhaOracle force-pushed the NPE-ImportVM branch 2 times, most recently from 1457cfc to 9884389 Compare March 21, 2024 15:24
@sandrobonazzola sandrobonazzola requested review from BrooklynDewolf and removed request for ljelinkova July 1, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgratch sgratch Awaiting requested review from sgratch sgratch is a code owner

@dupondje dupondje Awaiting requested review from dupondje

@BrooklynDewolf BrooklynDewolf Awaiting requested review from BrooklynDewolf

Assignees

@shubhaOracle shubhaOracle

Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubhaOracle @dupondje @sandrobonazzola