Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"secure boot" not getting enabled for Chipset/Firmware Type "Q35 Chipset with UEFI SecureBoot" #912

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

saksham-oracle
Copy link
Contributor

@saksham-oracle saksham-oracle commented Jan 11, 2024

Issue:
When VM emulator is changed to Q35 Chipset with UEFI SecureBoot from Q35 Chipset with UEFI, the NVRAM file needs to be rewritten.

Fix:
On VM update remove the previous NVRAM file.

Signed-off-by: Saksham Srivastava [email protected]

Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smelamud can you please review?

@smelamud
Copy link
Member

This change seems to be an addition to #887. That PR puts a new condition here: IF (OLD.bios_type = 4 AND NEW.bios_type != 4) OR (OLD.bios_type = 3 AND NEW.bios_type < 3) THEN. It is possible to change it to IF (OLD.bios_type = 4 AND NEW.bios_type != 4) OR (OLD.bios_type = 3 AND NEW.bios_type != 3) THEN to include this case also.

Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as patch is already out in OLVM ovirt-engine-4.5.5-1.21.el8, tested by Oracle's QE and shipped to Oracle's customers.

…set with UEFI SecureBoot".

Issue:
When VM emulator is changed to Q35 Chipset with UEFI SecureBoot from Q35 Chipset with UEFI, the NVRAM file needs to be rewritten.

Fix:
On VM update remove the previous NVRAM file.

Signed-off-by: Saksham Srivastava <[email protected]>
@sandrobonazzola sandrobonazzola merged commit 075b17c into oVirt:master Oct 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants