Replace deprecated imp module with importlib for Python compatibility #1465
Conversation
There was a problem hiding this comment.
Regardless it seems to me like this repo isn't really maintained at the moment. There are a number of open PRs which are ready to be merged as far as I can tell, but haven't been. I have opened an issue #1466 with regards to the status of the project, so hopefully someone will pick up the maintenance and your PR can be properly sorted out.
There was a problem hiding this comment.
I'm not sure exactly what is going on here
Edit: It looks like somehow your settings have made it into the PR
There was a problem hiding this comment.
If you aren't doing anything on error, surely it would just be better to remove the try entirely. If load_source isn't available, it will fail later on with the instantiation of Settings at the bottom anyway, leading to a more confusing error message.
Replaced all usages of the deprecated imp module with importlib to ensure compatibility with Python 3.12 and beyond.