Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move didmethods to config root #3439

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Move didmethods to config root #3439

merged 6 commits into from
Oct 3, 2024

Conversation

gerardsn
Copy link
Member

@gerardsn gerardsn commented Oct 2, 2024

No description provided.

@gerardsn gerardsn force-pushed the move-didmethods-to-config-root branch from 091ee9a to fae7df9 Compare October 2, 2024 10:23
@reinkrul
Copy link
Member

reinkrul commented Oct 2, 2024

Why?

@gerardsn
Copy link
Member Author

gerardsn commented Oct 2, 2024 •
edited
Loading

didmethods is used in multiple modules. Should have been on root from the start to prevent other modules having a dependency on VDR just for this.

Current problem is that it creates a crcular dependency between VDR and Network

@gerardsn gerardsn force-pushed the move-didmethods-to-config-root branch from 9f34a3c to e75b91a Compare October 3, 2024 10:59
@gerardsn gerardsn merged commit d888d2c into master Oct 3, 2024
8 of 9 checks passed
@gerardsn gerardsn deleted the move-didmethods-to-config-root branch October 3, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutslakhorst woutslakhorst woutslakhorst approved these changes

@reinkrul reinkrul reinkrul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gerardsn @reinkrul @woutslakhorst