Enable did:jwk resolving #2396
Merged
Enable did:jwk resolving #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerardsn
reviewed
Aug 3, 2023
|
I'm thinking more of integration-style tests, but not sure yet how |
|
For did:web I wrote a simple test resolving a stubbed did:web document (see #2382). I will do the same for did:jwk after the did:web PR is merged. End-to-end doesn't make much sense for now (at least for did:web), since we can't serve did:web from the Nuts node yet. did:jwk is mainly meant for mobile wallets, so an end-to-end test would involve mimicking one. But that part of an OpenID4VP flow, which we have yet to build. |
gerardsn
approved these changes
Aug 4, 2023
reinkrul
force-pushed
the
enable-didjwk
branch
from
19b3d6f
to
c55ae82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.