Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serverless fn NUS auth user endpoint #3644

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chrisgzf
Copy link
Member

Adds a new serverless fn endpoint that provides user data given a valid SAML token.

Copy link

vercel bot commented Dec 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2023 10:21am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2023 10:21am

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (17c4bc3) 53.24% compared to head (093edd0) 53.14%.

Files Patch % Lines
website/src/serverless/nus-auth.ts 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3644      +/-   ##
==========================================
- Coverage   53.24%   53.14%   -0.10%     
==========================================
  Files         271      271              
  Lines        5862     5873      +11     
  Branches     1396     1398       +2     
==========================================
  Hits         3121     3121              
- Misses       2741     2752      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisgzf chrisgzf requested a review from a team December 17, 2023 10:23
Copy link
Member

@ravern ravern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants