[T4A3][T17-B3]Sin Yu Fan #1692
Open
[T4A3][T17-B3]Sin Yu Fan #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lasses. Extract common variables and methods.
bongbongbee
reviewed
Sep 17, 2016
| && this.value.equals(((Phone) other).value)); // state check | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { |
There was a problem hiding this comment.
What's the rationale behind overriding the hashCode() method? Or did you forget to remove this?
| && this.value.equals(((Phone) other).value)); // state check | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return value.hashCode(); |
There was a problem hiding this comment.
hmm..the value variable does not exist in your Phone class already. Can this class file still compile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new Contact class - parent class of Address, Email and Phone classes.
Extract common variables and methods.