[T4A2][T17-B3]Sin Yu Fan #1691
Open
[T4A2][T17-B3]Sin Yu Fan #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iewAll, parseArgsAsDisplayedIndex, prepareFind methods to static. Add private sequenceNumber variable and public static nextSequenceNumber to person class.
bongbongbee
reviewed
Sep 17, 2016
There was a problem hiding this comment.
Since I don't see any commits on changes made to Main.java and ParserTest.java, I'm guessing you may have forgotten to change the code where your Parser.parseCommand(...) method is used. It should be changed to Parser.parseCommand(...) in Main class and ParserTest class.
| @@ -14,6 +14,9 @@ | |||
| private Phone phone; | |||
| private Email email; | |||
| private Address address; | |||
|
|
|||
| private int sequenceNumber; | |||
| public static int nextSequenceNumber = 1; | |||
There was a problem hiding this comment.
nextSequenceNumber should be private
|
@howitzerg Some comments added. Please close the PR after reading comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change parseCommand, prepareAdd, prepareDelete, prepareView, prepareViewAll, parseArgsAsDisplayedIndex, prepareFind methods to static.
Add private sequenceNumber variable and public static nextSequenceNumber to person class.