Extract helper methods in Describer class to create developer hooks #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracting helper methods like this makes it easier for developers wanting to customize the output to hook into specific parts of the existing logic. For example, I wanted to extend the Describer class to customize just the sorting of the commands, but am forced to reimplement the entire method, which increases the amount of code I need to maintain, and makes it harder to stay in sync with updates to this package. Being able to just extend the single method makes the code much cleaner and more extendable.
|
@owenvoke Would you mind taking a look at this? |
caendesilva
added a commit
to hydephp/cli
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting helper methods like this makes it easier for developers wanting to customize the output to hook into specific parts of the existing logic.
For example, I wanted to extend the Describer class to customize just the sorting of the commands, but am forced to reimplement the entire method, which increases the amount of code I need to maintain, and makes it harder to stay in sync with updates to this package.
Being able to just extend the single method makes the code much cleaner and more extendable.