feat: capture filesystems #74
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian McGee <[email protected]>
brianmcgee
force-pushed
the
feat/capture-filesystems
branch
from
638c94e
to
9793a63
Compare
phaer
reviewed
Aug 25, 2024
| "github.com/moby/sys/mountinfo" | ||
| ) | ||
|
|
||
| var specialFsRegex = regexp.MustCompile(`^(/proc|/dev|/sys|/run|/var/lib/docker|/var/lib/nfs/rpc_pipefs).*`) |
There was a problem hiding this comment.
It's not entirely clear for me what's a "special" filesystem here. Makes sense to filter /proc, /sys, etc. as we are looking for block devices containing file systems. But why /var/lib/docker? Too me, this seems a bit too specific for this layer.
| @@ -86,7 +86,8 @@ func init() { | |||
|
|
|||
| // Options for optional ephemeral system properties. | |||
| f.BoolVarP(&scanner.Swap, "swap", "s", false, "capture swap entries") | |||
| f.BoolVarP(&scanner.Ephemeral, "ephemeral", "e", false, "capture all ephemeral properties e.g. swap, filesystems and so on") | |||
| f.BoolVarP(&scanner.Mounts, "mounts", "m", false, "capture filesystem mounts") | |||
| f.BoolVarP(&scanner.Ephemeral, "ephemeral", "e", false, "capture all ephemeral properties e.g. swap, mounts and so on") | |||
There was a problem hiding this comment.
ephemeral seems to contains only SwapEntries, no "mounts and so on"? Or am I misreading?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9