Check the number of digits at the casting

nttcom · Jun 11, 2024 · 076cad8 · 076cad8
1 parent c2ca200
commit 076cad8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/internal/pkg/table/sr_policy.go b/internal/pkg/table/sr_policy.go
@@ -86,6 +86,8 @@ func (p *SRPolicy) Update(df PolicyDiff) {
 	}
 }
 
+const SRV6_SID_BIT_LENGTH = 128
+
 type Segment interface {
 	SidString() string
 }

diff --git a/pkg/server/grpc_server.go b/pkg/server/grpc_server.go
@@ -133,7 +133,11 @@ func (s *APIServer) createSRPolicy(_ context.Context, input *pb.CreateSRPolicyIn
 						if err != nil {
 							return &pb.RequestStatus{IsSuccess: false}, errors.New("invalid SidStructure information")
 						}
-						segSRv6.Structure = append(segSRv6.Structure, uint8(elem))
+						if elem <= table.SRV6_SID_BIT_LENGTH {
+							segSRv6.Structure = append(segSRv6.Structure, uint8(elem))
+						} else {
+							return &pb.RequestStatus{IsSuccess: false}, errors.New("element of each Sid Structure less than bit length of SRv6 SID")
+						}
 					}
 
 				}

diff --git a/pkg/server/server.go b/pkg/server/server.go
@@ -6,6 +6,8 @@
 package server
 
 import (
+	"errors"
+	"math"
 	"net"
 	"net/netip"
 	"strconv"
@@ -88,6 +90,9 @@ func (s *Server) Serve(address string, port string, usidMode bool) error {
 	if err != nil {
 		return err
 	}
+	if p > math.MaxUint16 {
+		return errors.New("invalid PCEP listen port")
+	}
 	localAddr := netip.AddrPortFrom(a, uint16(p))
 
 	s.logger.Info("Start listening on PCEP port", zap.String("address", localAddr.String()))