feat(js): generate experimental simplified library with ts solution setup

docs/generated/packages/js/generators/init.json

@@ -1,13 +1,19 @@
 {
   "name": "init",
-  "factory": "./src/generators/init/init#initGenerator",
+  "factory": "./src/generators/init/init#initGeneratorInternal",
   "schema": {
     "$schema": "https://json-schema.org/schema",
     "$id": "NxTypescriptInit",
     "cli": "nx",
     "title": "Init nx/js",
     "description": "Init generator placeholder for nx/js.",
     "properties": {
+      "formatter": {
+        "description": "The tool to use for code formatting.",
+        "type": "string",
+        "enum": ["none", "prettier"],
+        "default": "none"
+      },
       "js": {
         "type": "boolean",
         "default": false,
@@ -40,12 +46,6 @@
         "type": "string",
         "description": "Customize the generated base tsconfig file name.",
         "x-priority": "internal"
-      },
-      "setUpPrettier": {
-        "type": "boolean",
-        "description": "Add Prettier and corresponding configuration files.",
-        "x-priority": "internal",
-        "default": false
       }
     },
     "presets": []
@@ -54,7 +54,7 @@
   "x-type": "init",
   "description": "Initialize a TS/JS workspace.",
   "hidden": true,
-  "implementation": "/packages/js/src/generators/init/init#initGenerator.ts",
+  "implementation": "/packages/js/src/generators/init/init#initGeneratorInternal.ts",
   "path": "/packages/js/src/generators/init/schema.json",
   "type": "generator"
 }

docs/generated/packages/js/generators/library.json

@@ -21,22 +21,28 @@
         "description": "A directory where the lib is placed.",
         "x-priority": "important"
       },
-      "projectNameAndRootFormat": {
-        "description": "Whether to generate the project name and root directory as provided (`as-provided`) or generate them composing their values and taking the configured layout into account (`derived`).",
+      "bundler": {
+        "description": "The bundler to use. Choosing 'none' means this library is not buildable.",
         "type": "string",
-        "enum": ["as-provided", "derived"]
+        "enum": ["swc", "tsc", "rollup", "vite", "esbuild", "none"],
+        "x-priority": "important"
       },
       "linter": {
         "description": "The tool to use for running lint checks.",
         "type": "string",
-        "enum": ["eslint", "none"],
-        "default": "eslint"
+        "enum": ["none", "eslint"],
+        "x-priority": "important"
       },
       "unitTestRunner": {
-        "type": "string",
-        "enum": ["jest", "vitest", "none"],
         "description": "Test runner to use for unit tests.",
-        "x-prompt": "Which unit test runner would you like to use?"
+        "type": "string",
+        "enum": ["none", "jest", "vitest"],
+        "x-priority": "important"
+      },
+      "projectNameAndRootFormat": {
+        "description": "Whether to generate the project name and root directory as provided (`as-provided`) or generate them composing their values and taking the configured layout into account (`derived`).",
+        "type": "string",
+        "enum": ["as-provided", "derived"]
       },
       "tags": {
         "type": "string",
@@ -118,18 +124,9 @@
       "compiler": {
         "type": "string",
         "enum": ["tsc", "swc"],
-        "default": "tsc",
         "description": "The compiler used by the build and test targets",
         "x-deprecated": "Use the `bundler` option for greater control (swc, tsc, rollup, vite, esbuild, none)."
       },
-      "bundler": {
-        "description": "The bundler to use. Choosing 'none' means this library is not buildable.",
-        "type": "string",
-        "enum": ["swc", "tsc", "rollup", "vite", "esbuild", "none"],
-        "default": "tsc",
-        "x-prompt": "Which bundler would you like to use to build the library? Choose 'none' to skip build setup.",
-        "x-priority": "important"
-      },
       "skipTypeCheck": {
         "type": "boolean",
         "description": "Whether to skip TypeScript type checking for SWC compiler.",
@@ -144,6 +141,10 @@
         "description": "Don't include the directory in the generated file name.",
         "type": "boolean",
         "default": false
+      },
+      "useProjectJson": {
+        "type": "boolean",
+        "description": "Use a `project.json` configuration file instead of inlining the Nx configuration in the `package.json` file."
       }
     },
     "required": ["name"],

packages/create-nx-workspace/bin/create-nx-workspace.ts

@@ -37,9 +37,10 @@ interface BaseArguments extends CreateWorkspaceOptions {
 
 interface NoneArguments extends BaseArguments {
   stack: 'none';
-  workspaceType: 'package-based' | 'integrated' | 'standalone';
-  js: boolean;
-  appName: string | undefined;
+  workspaceType?: 'package-based' | 'integrated' | 'standalone';
+  js?: boolean;
+  appName?: string | undefined;
+  formatter?: 'none' | 'prettier';
 }
 
 interface ReactArguments extends BaseArguments {
@@ -394,7 +395,10 @@ async function determineStack(
       choices: [
         {
           name: `none`,
-          message: `None:          Configures a TypeScript/JavaScript project with minimal structure.`,
+          message:
+            process.env.NX_ADD_TS_PLUGIN === 'true'
+              ? `None:          Configures a TypeScript/JavaScript monorepo.`
+              : `None:          Configures a TypeScript/JavaScript project with minimal structure.`,
         },
         {
           name: `react`,
@@ -441,34 +445,11 @@ async function determinePresetOptions(
 async function determineNoneOptions(
   parsedArgs: yargs.Arguments<NoneArguments>
 ): Promise<Partial<NoneArguments>> {
-  let preset: Preset;
-  let workspaceType: 'package-based' | 'standalone' | 'integrated' | undefined =
-    undefined;
-  let appName: string | undefined = undefined;
-  let js: boolean | undefined;
-
-  if (parsedArgs.preset) {
-    preset = parsedArgs.preset;
-  } else {
-    workspaceType = await determinePackageBasedOrIntegratedOrStandalone();
-    if (workspaceType === 'standalone') {
-      preset = Preset.TsStandalone;
-    } else if (workspaceType === 'integrated') {
-      preset = Preset.Apps;
-    } else {
-      preset = Preset.NPM;
-    }
-  }
-
-  if (parsedArgs.js !== undefined) {
-    js = parsedArgs.js;
-  } else if (preset === Preset.TsStandalone) {
-    // Only standalone TS preset generates a default package, so we need to provide --js and --appName options.
-    appName = parsedArgs.name;
-    const reply = await enquirer.prompt<{ ts: 'Yes' | 'No' }>([
+  if (process.env.NX_ADD_TS_PLUGIN === 'true') {
+    const reply = await enquirer.prompt<{ prettier: 'Yes' | 'No' }>([
       {
-        name: 'ts',
-        message: `Would you like to use TypeScript with this project?`,
+        name: 'prettier',
+        message: `Would you like to use Prettier for code formatting?`,
         type: 'autocomplete',
         choices: [
           {
@@ -478,14 +459,64 @@ async function determineNoneOptions(
             name: 'No',
           },
         ],
-        initial: 0,
+        initial: 1,
         skip: !parsedArgs.interactive || isCI(),
       },
     ]);
-    js = reply.ts === 'No';
-  }
+    return {
+      preset: Preset.TS,
+      formatter: reply.prettier === 'Yes' ? 'prettier' : 'none',
+    };
+  } else {
+    let preset: Preset;
+    let workspaceType:
+      | 'package-based'
+      | 'standalone'
+      | 'integrated'
+      | undefined = undefined;
+    let appName: string | undefined = undefined;
+    let js: boolean | undefined;
+
+    if (parsedArgs.preset) {
+      preset = parsedArgs.preset;
+    } else {
+      workspaceType = await determinePackageBasedOrIntegratedOrStandalone();
+      if (workspaceType === 'standalone') {
+        preset = Preset.TsStandalone;
+      } else if (workspaceType === 'integrated') {
+        preset = Preset.Apps;
+      } else {
+        preset = Preset.NPM;
+      }
+    }
 
-  return { preset, js, appName };
+    if (parsedArgs.js !== undefined) {
+      js = parsedArgs.js;
+    } else if (preset === Preset.TsStandalone) {
+      // Only standalone TS preset generates a default package, so we need to provide --js and --appName options.
+      appName = parsedArgs.name;
+      const reply = await enquirer.prompt<{ ts: 'Yes' | 'No' }>([
+        {
+          name: 'ts',
+          message: `Would you like to use TypeScript with this project?`,
+          type: 'autocomplete',
+          choices: [
+            {
+              name: 'Yes',
+            },
+            {
+              name: 'No',
+            },
+          ],
+          initial: 0,
+          skip: !parsedArgs.interactive || isCI(),
+        },
+      ]);
+      js = reply.ts === 'No';
+    }
+
+    return { preset, js, appName };
+  }
 }
 
 async function determineReactOptions(

packages/eslint/src/generators/lint-project/lint-project.ts

@@ -106,13 +106,15 @@ export async function lintProjectGeneratorInternal(
         (p) => !['./src', '{projectRoot}', projectConfig.root].includes(p)
       )
     ) {
+      projectConfig.targets ??= {};
       projectConfig.targets['lint'] = {
         command: `eslint ${lintFilePatterns
           .join(' ')
           .replace('{projectRoot}', projectConfig.root)}`,
       };
     }
   } else {
+    projectConfig.targets ??= {};
     projectConfig.targets['lint'] = {
       executor: '@nx/eslint:lint',
     };

packages/js/generators.json

@@ -10,7 +10,7 @@
       "description": "Create a library"
     },
     "init": {
-      "factory": "./src/generators/init/init#initGenerator",
+      "factory": "./src/generators/init/init#initGeneratorInternal",
       "schema": "./src/generators/init/schema.json",
       "aliases": ["lib"],
       "x-type": "init",

packages/js/package.json

@@ -41,12 +41,14 @@
     "@babel/runtime": "^7.22.6",
     "@nx/devkit": "file:../devkit",
     "@nx/workspace": "file:../workspace",
+    "@zkochan/js-yaml": "0.0.7",
     "babel-plugin-const-enum": "^1.0.1",
     "babel-plugin-macros": "^2.8.0",
     "babel-plugin-transform-typescript-metadata": "^0.3.1",
     "chalk": "^4.1.0",
     "columnify": "^1.6.0",
     "detect-port": "^1.5.1",
+    "enquirer": "~2.3.6",
     "fast-glob": "3.2.7",
     "ignore": "^5.0.4",
     "js-tokens": "^4.0.0",

packages/js/src/generators/convert-to-swc/convert-to-swc.spec.ts

@@ -3,7 +3,7 @@ import 'nx/src/internal-testing-utils/mock-project-graph';
 import { readProjectConfiguration, Tree } from '@nx/devkit';
 import { createTreeWithEmptyWorkspace } from '@nx/devkit/testing';
 import { join } from 'path';
-import { LibraryGeneratorSchema } from '../../utils/schema';
+import { LibraryGeneratorSchema } from '../library/schema';
 import { libraryGenerator as jsLibraryGenerator } from '../library/library';
 import { convertToSwcGenerator } from './convert-to-swc';
 

packages/js/src/generators/init/files/ts-solution/tsconfig.base.json__tmpl__

@@ -0,0 +1,33 @@
+{
+  "compilerOptions": {
+    "allowJs": false,
+    "allowSyntheticDefaultImports": true,
+    "composite": true,
+    "declaration": true,
+    "declarationMap": true,
+    "emitDeclarationOnly": true,
+    "emitDecoratorMetadata": false,
+    "esModuleInterop": true,
+    "experimentalDecorators": false,
+    "forceConsistentCasingInFileNames": true,
+    "incremental": true,
+    "isolatedModules": true,
+    "lib": ["es2022"],
+    "module": "NodeNext",
+    "moduleResolution": "NodeNext",
+    "noEmitOnError": true,
+    "noFallthroughCasesInSwitch": true,
+    "noImplicitOverride": true,
+    "noImplicitReturns": true,
+    "noUnusedLocals": true,
+    "pretty": true,
+    "removeComments": false,
+    "resolveJsonModule": false,
+    "skipDefaultLibCheck": false,
+    "skipLibCheck": true,
+    "sourceMap": false,
+    "strict": true,
+    "target": "es2022",
+    "verbatimModuleSyntax": false
+  }
+}

packages/js/src/generators/init/files/ts-solution/tsconfig.json__tmpl__

@@ -0,0 +1,6 @@
+{
+  "extends": "./tsconfig.base.json",
+  "compileOnSave": false,
+  "files": [],
+  "references": []
+}

packages/js/src/generators/init/init.spec.ts

@@ -131,7 +131,7 @@ describe('js init generator', () => {
 
   it('should support skipping prettier setup', async () => {
     await init(tree, {
-      setUpPrettier: false,
+      formatter: 'none',
     });
 
     const packageJson = readJson(tree, 'package.json');