feat(js): update js init generator to not set addPlugins to false pro…

…grammatically
nrwl · Sep 19, 2024 · aaa0202 · aaa0202
1 parent a8a3428
commit aaa0202
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/packages/js/src/generators/init/init.ts b/packages/js/src/generators/init/init.ts
@@ -71,7 +71,6 @@ export async function initGenerator(
   return initGeneratorInternal(tree, {
     addTsConfigBase: true,
     formatter: 'prettier',
-    addPlugin: false,
     ...schema,
   });
 }

diff --git a/packages/js/src/generators/library/library.ts b/packages/js/src/generators/library/library.ts
@@ -859,6 +859,8 @@ async function normalizeOptions(
   // TODO(leo): log a warning if the user explicitly sets useProjectJson to true
   // and the project is not in the workspaces config. Also, consider automatically
   // adding the project to the workspaces config if it's not there.
+  // TODO(leo): if the library root is not in workspaces but user has workspaces enabled, this should throw or warn -- or provide a way to remedy.
+  /// We should not just add to `compilerOptions.paths`
   options.useProjectJson ??= hasPlugin
     ? !isProjectInPackageManagerWorkspaces(tree, projectRoot)
     : true;