-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented eslint problem matcher #2027
base: master
Are you sure you want to change the base?
Conversation
…rwl#2025) Signed-off-by: Max Kless <[email protected]>
Thanks so much for submitting this PR! I'll look into it and give it a try :) |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b66c7ea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It works great when running tasks from the project view.
However, there's additional places we should consider:
- using the
Nx: run
andNx: run target
commands should also populate the problems pane - running the target from the tooltip in the integrated graph & project details view should also populate the problems pane
- running the target from the
Generate & Run Target
view should also populate the problems pane
I think the easiest solution here is to check for the problemMatchers right inside CliTaskProvider.executeTask
. You can use the positional
argument when command === run
, split it by :
and check if it's a lint target. In that case, pass the problem matchers to the task.
Thanks a lot for this contribution it rocks!
P.S. also make sure to format your code with npx nx format --fix
to make sure it passes CI :)
629dc4b
to
ec50b72
Compare
Hey :) Am I missing something or are a lot of the places where we could be running tasks from still not integrated here? |
I propose to have NX-console-extension to support the VSCode problemmatcher functionality for eslint-tasks.