Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: sdk-connectedhomeip: Fix reliability issues with multicasts #17633

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LuDuda
Copy link
Contributor

@LuDuda LuDuda commented Oct 3, 2024

This commit updates the Matter SDK revision to include fixes that improve the reliability of multicast message delivery by enabling MLDv2 reporting.

Btw. After this is merged i do plan to backport the fix to NCS 2.6 and 2.7 branches as well.

This commit updates the Matter SDK revision to include fixes that
improve the reliability of multicast message delivery by enabling MLDv2
reporting.

Signed-off-by: Łukasz Duda <[email protected]>
@LuDuda LuDuda added the bugfix Fixes a known bug label Oct 3, 2024
@LuDuda LuDuda added this to the 2.8.0 milestone Oct 3, 2024
@LuDuda LuDuda requested review from a team as code owners October 3, 2024 20:29
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 3, 2024
@NordicBuilder
Copy link
Contributor

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@89eb37b (master) nrfconnect/sdk-connectedhomeip#486 nrfconnect/sdk-connectedhomeip#486/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 3, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: c89b9849df710127513e5ec6a3560d1b683617ef
matter: PR head: aaf528b3877eb3be3f37b73ba8213743ca104367

more details

sdk-nrf:

PR head: c89b9849df710127513e5ec6a3560d1b683617ef
merge base: 547aaab19c52cc03660d57943a963480a042e14f
target head (main): 547aaab19c52cc03660d57943a963480a042e14f
Diff

matter:

PR head: aaf528b3877eb3be3f37b73ba8213743ca104367
merge base: 89eb37b47ca8e4b9d309c431bde30bdb19d07577
target head (master): 89eb37b47ca8e4b9d309c431bde30bdb19d07577
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  │ known_issues.rst
modules
│  ├── lib
│  │  ├── matter
│  │  │  ├── src
│  │  │  │  ├── platform
│  │  │  │  │  ├── nrfconnect
│  │  │  │  │  │  │ ConnectivityManagerImpl.cpp
west.yml

Outputs:

Toolchain

Version: 9583beca34
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:9583beca34_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 128
  • ❌ Integration tests
    • ❌ test-fw-nrfconnect-chip - Error: Error starting job: null
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

.. rst-class:: v2-7-0 v2-6-2 v2-6-1 v2-6-0 v2-5-3 v2-5-2 v2-5-1 v2-5-0 v2-4-4 v2-4-3 v2-4-2 v2-4-1 v2-4-0

KRKNWK-19524: Reliability issues with multicast message delivery for certain Access Points.
Certain Access Points require Wi-Fi devices to send MLDv2 (Multicast Listener Discovery version 2) Report messages in order for multicast packets to be properly delivered to a given address.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Certain Access Points require Wi-Fi devices to send MLDv2 (Multicast Listener Discovery version 2) Report messages in order for multicast packets to be properly delivered to a given address.
Certain Access Points require Wi-Fi devices to send Multicast Listener Discovery version 2 (MLDv2) Report messages for multicast packets to be properly delivered to a given address.

Certain Access Points require Wi-Fi devices to send MLDv2 (Multicast Listener Discovery version 2) Report messages in order for multicast packets to be properly delivered to a given address.
Matter over Wi-Fi devices only subscribed to multicast addresses within the internal IPv6 stack, without notifying the Access Points, leading to reliability issues with multicast message delivery.

**Workaround:** To ensure reliable multicast communication, use the ``net_ipv6_mld_join`` and ``net_ipv6_mld_leave`` functions to explicitly subscribe or unsubscribe to multicast addresses.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Workaround:** To ensure reliable multicast communication, use the ``net_ipv6_mld_join`` and ``net_ipv6_mld_leave`` functions to explicitly subscribe or unsubscribe to multicast addresses.
**Workaround:** To ensure reliable multicast communication, use the :c:func:`net_ipv6_mld_join` and :c:func:`net_ipv6_mld_leave` functions to explicitly subscribe or unsubscribe to multicast addresses.

Matter over Wi-Fi devices only subscribed to multicast addresses within the internal IPv6 stack, without notifying the Access Points, leading to reliability issues with multicast message delivery.

**Workaround:** To ensure reliable multicast communication, use the ``net_ipv6_mld_join`` and ``net_ipv6_mld_leave`` functions to explicitly subscribe or unsubscribe to multicast addresses.
For reference, you can refer to the commit with the fix in the ``sdk-connectedhomeip`` repository (commit hash: ``TBD``).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For reference, you can refer to the commit with the fix in the ``sdk-connectedhomeip`` repository (commit hash: ``TBD``).
For reference, see the commit with the fix in the ``sdk-connectedhomeip`` repository (commit hash: ``TBD``).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM doc-required PR must not be merged without tech writer approval. manifest manifest-matter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants