lib: nrf_modem_lib: Turn off CONFIG_COAP_CLIENT_TRUNCATE_MSGS #17587
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plskeggs
requested review from
a team,
stephen-nordic,
magnev,
nordicjm,
nordic-auko,
MirkoCovizzi,
trantanen,
tokangas,
carlescufi,
katgiadla,
tejlmand,
wentong-li,
bama-nordic,
krish2718 and
sachinthegreen
as code owners
github-actions
bot
added
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 72c1ec50740bb8762fe603155bd955561fe6ab45 more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)Outputs:ToolchainVersion: 9583beca34 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
glarsennordic
approved these changes
Oct 1, 2024
trantanen
approved these changes
Oct 2, 2024
rlubos
approved these changes
Oct 2, 2024
lemrey
approved these changes
Oct 2, 2024
plskeggs
force-pushed
the
coap-client-turn-off-msg-truncate-flag
branch
from
0a20363
to
205ff15
Compare
plskeggs
changed the title
plskeggs
removed
DNM
changelog-entry-required
plskeggs
force-pushed
the
coap-client-turn-off-msg-truncate-flag
branch
from
205ff15
to
3000bf9
Compare
github-actions
bot
added
the
changelog-entry-required
nordicjm
reviewed
Oct 4, 2024
This upstream Kconfig defaults to y, but is not compatible with the modem's socket implementation. Signed-off-by: Pete Skeggs <[email protected]>
plskeggs
force-pushed
the
coap-client-turn-off-msg-truncate-flag
branch
from
3000bf9
to
72c1ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prepare for eventual upmerge of zephyrproject-rtos/zephyr#79155. An earlier version of that is included in the pre-NCS 2.8.0 upmerge already, but that earlier version had the new Kconfig defaulting to n.
This upstream Zephyr PR will default it to y, but is not compatible with the modem's socket implementation, so turn it off here.