fix(arborist): check placed node children for missing deps (#7746) #7752
+46,386
−14,973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Aug 25, 2024
2 tasks
This addresses an edge case where a dep could be placed in the tree with unsatisfied indirect dependencies (see test case).
TrevorBurnham
force-pushed
the
7746-bug-fix
branch
from
f73d07f
to
9a6738d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an edge case where a dep could be placed in the tree with unsatisfied indirect dependencies (see test case), by adding the children of placed deps to the
#depsQueue.See #7746 for details on this bug. As far as I know, this situation only occurs if the lockfile has been manipulated outside of npm; even so, I believe it's worth addressing within npm in order to ensure that the state of the lockfile is consistent (i.e. running
npm installmore than once does not change the result).This is my first time working with the npm codebase. I'd welcome any suggestions!
References
Fixes #7746