Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hydration fee #304

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix: hydration fee #304

merged 2 commits into from
Sep 24, 2024

Conversation

stepanLav
Copy link
Member

@stepanLav stepanLav commented Sep 24, 2024 •
edited
Loading

That PR changes logic for Hydration fee assign for swap feature.
It is done to handle this error:

Failed to index block 5604555: TypeError: Cannot read properties of undefined (reading 'tokenId') at t.handleHydraRouterSwap (webpack://subquery-nova/src/mappings/swaps/HydraDx.ts:59:24) TypeError: Cannot read properties of undefined (reading 'tokenId') at t.handleHydraRouterSwap (webpack://subquery-nova/src/mappings/swaps/HydraDx.ts:59:24)

That happens, when we can't find event with fee, for example for that swap - https://hydration.subscan.io/extrinsic/5604555-2?event=5604555-28

Tested by:
Screenshot 2024-09-24 at 15 37 48
Screenshot 2024-09-24 at 15 38 21

@stepanLav stepanLav merged commit c5a4556 into master Sep 24, 2024
1 check passed
@stepanLav stepanLav deleted the fix/hydration_swap_fee branch September 24, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ERussel ERussel ERussel approved these changes

@valentunn valentunn valentunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stepanLav @ERussel @valentunn