Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use argcomplete to auto-generate autocompletion #269

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

soraxas
Copy link
Contributor

@soraxas soraxas commented Dec 11, 2023

The use of argcomplete is much more robust and it works on many different shells. This also makes the auto-complete very much up-to-date when we change gita in the future.

The only downside is that gita now depends on argcomplete, which I think is reasonable dependency.

@nosarthur
Copy link
Owner

please keep the original autocompletion scripts as alternatives

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b70e72) 86.27% compared to head (6b8d4d2) 86.43%.

❗ Current head 6b8d4d2 differs from pull request most recent head 9963986. Consider uploading reports for the commit 9963986 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   86.27%   86.43%   +0.16%     
==========================================
  Files           5        5              
  Lines         794      796       +2     
==========================================
+ Hits          685      688       +3     
+ Misses        109      108       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soraxas
Copy link
Contributor Author

soraxas commented Dec 11, 2023

Yep, no problem

@nosarthur nosarthur merged commit 1b6319b into nosarthur:master Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants