NDFD GRIB data support part 4: correctly handle cases where nbit is 0 in the complex packing decoder #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te 5.2/7.2 support" This reverts commit 30cba06.
The logic for decoding complex packing when nbit is 0 was incorrect and wrong values were output. This is due to the fact that I added support for "nbit=0" cases in 26dd5dd based on a wrong understanding and tests happened to pass with the data used for confirmation. This time I read the source code of wgrib2 and revised my understanding of the specification. Thanks wgrib2!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Code Table 5.5 (missing value management for complex packing).
The logic for decoding complex packing when nbit is 0 was incorrect and wrong values were output.
The reason was that I wrote the process based on an incorrect understanding.
This time I read the source code of wgrib2, understood it again, and rewrote the process.
This is the 4th step of NDFD GRIB data support discussed in #59.