NDFD GRIB data support part 1: skip non-GRIB byte sequences between messages #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es exist in-between The process of reading Section 0 has been rewritten from scratch so that the next message is read even if an arbitrary byte sequence is inserted before the message. This change has changed the behavior of the reader, as the byte sequence given to the reader is no longer expected to start with `GRIB`, so errors caused by failure to read `GRIB` no longer occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the reader so that it skips non-GRIB byte sequences between messages.
This is the 1st step of NDFD GRIB data support discussed in #59.