Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow nested ternaries #62

Merged
merged 1 commit into from
Dec 18, 2023
Merged

feat: allow nested ternaries #62

merged 1 commit into from
Dec 18, 2023

Conversation

nowyDEV
Copy link
Member

@nowyDEV nowyDEV commented Dec 18, 2023

What

  • Nested ternaries are ok, especially when they are properly formatted (prettier should improve it soon)

Compatibility

  • Does this change maintain backward compatibility?

@nowyDEV nowyDEV added the enhancement New feature or request label Dec 18, 2023
@nowyDEV nowyDEV self-assigned this Dec 18, 2023
@nowyDEV nowyDEV requested a review from a team as a code owner December 18, 2023 20:25
github-actions[bot]
github-actions bot reviewed Dec 18, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@nowyDEV nowyDEV merged commit eaa1b8d into master Dec 18, 2023
2 checks passed
@nowyDEV nowyDEV deleted the update-common-config branch December 18, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

Assignees

@nowyDEV nowyDEV

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nowyDEV