Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3004866 by tarekdj: Fix failing tests #33

Open
wants to merge 24 commits into
base: 8.x-6.x
Choose a base branch
from

Conversation

tarekdj
Copy link

@tarekdj tarekdj commented Oct 6, 2018

This is a work in progress...

@tarekdj
Copy link
Author

tarekdj commented Oct 8, 2018

@nignatov tests are passing on my local setup. On circle-ci we have issues with Kernel tests. I'm not sure but I think it's related to https://www.drupal.org/node/2931730.
Note: I'm suspecting a failure on sqlite (it works for me on mariadb)

@tarekdj tarekdj changed the title [WIP] Issue #3004866 by tarekdj: Fix failing tests Issue #3004866 by tarekdj: Fix failing tests Oct 10, 2018
@tarekdj
Copy link
Author

tarekdj commented Oct 10, 2018

OK! I think we are done here. Behat , Unit and Kernel tests are passing. I think we can skip code coverage and cs checking.

@JTubex JTubex mentioned this pull request Nov 29, 2019
@JTubex
Copy link

JTubex commented Dec 12, 2019

Tests are no longer passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants