Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macos_arm64 exe #212

Merged
merged 1 commit into from
May 24, 2024
Merged

add macos_arm64 exe #212

merged 1 commit into from
May 24, 2024

Conversation

e-perl-NOAA
Copy link
Collaborator

Add SS3 executable for the arm64 version of macs.

@e-perl-NOAA e-perl-NOAA added the bug Something isn't working label May 20, 2024
@e-perl-NOAA e-perl-NOAA marked this pull request as draft May 20, 2024 21:06
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 69.75%. Comparing base (504429a) to head (3237fe8).
Report is 1 commits behind head on main.

Files Patch % Lines
R/runSS.R 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   69.76%   69.75%   -0.01%     
==========================================
  Files          21       21              
  Lines        4385     4387       +2     
==========================================
+ Hits         3059     3060       +1     
- Misses       1326     1327       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e-perl-NOAA e-perl-NOAA marked this pull request as ready for review May 21, 2024 18:51
Copy link
Collaborator

@k-doering-NOAA k-doering-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I had one comment that I'm not sure is relevant.

I also would like to squash the 5 commits before rebasing this commit into main, so I plan to do that once the comment is addressed.

R/runSS.R Show resolved Hide resolved
@k-doering-NOAA k-doering-NOAA merged commit 7fa3263 into main May 24, 2024
10 checks passed
@k-doering-NOAA k-doering-NOAA deleted the add_macos_arm64 branch May 24, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants