[1.10] Configure webhook dynamically #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anushkamittal2001 <[email protected]> Minor correction in comparison Signed-off-by: anushkamittal2001 <[email protected]> Changes in mutatingWebhookConfiguration Signed-off-by: anushkamittal2001 <[email protected]> Add minor change in variable declaration Signed-off-by: anushkamittal2001 <[email protected]> Correct comparison in controller.go Signed-off-by: anushkamittal2001 <[email protected]>
pns-nirmata
changed the title
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## release-1.10-n4k #46 +/- ##
====================================================
- Coverage 34.61% 34.53% -0.08%
====================================================
Files 222 223 +1
Lines 21367 21483 +116
====================================================
+ Hits 7396 7420 +24
- Misses 13222 13312 +90
- Partials 749 751 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pns-nirmata
commented
Sep 15, 2023
| operationStatusMap[webhookCreate] = true | ||
| operationStatusMap[webhookUpdate] = true | ||
|
|
||
| if r.HasGenerate() { |
There was a problem hiding this comment.
@anushkamittal2001 Can you check this?
There was a problem hiding this comment.
@pns-nirmata I think we are missing to add "connect"
|
Covered in PR combining the 3 performance PRs: #54 |
|
Closed accidentally. Changes still unmerged |
|
Merged separate PR to the 1.10 branch. Closing this one, had some test failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Replicate PR #31 for Kyverno 1.10, for kyverno#8313