fix(plug-in): use absolute paths to reference entry points #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before we can actually merge this browserify/brfs#37 needs to get fixed. Otherwise there is no other solution than to configure brfs as a global transform when using it with karma-browserify. |
nikku
force-pushed
the
52-fix
branch
2 times, most recently
from
cf1b663
to
7da92f8
Compare
This broke change detection for external resources included via brfs. Instead of relying on the logic we must rely on debouncing the bundle operation to suppress the double bundle. The delay before an actual bundling operation is triggered may now be configured via a browserify bundleDelay property in the karma configuration. Related to #69
This commit removes the prebundle hook to configure and adds the prebundle event that may be used to perform additional configuration. This allows users to reliably hook into the bundling process in browserify@7 times. Closes #63
This patch returns the browserify bundle instance so other injected services may make use of it. For example, a karma reporter may inject the browserify framework so it can track bundle build times. Currently the framework is `undefined` as far as the injector is concerned.
Adds a test runner for integration testing different setups. Incorporates integration tests into `npm test` as well. The test runner exposes the bundler instance for testing, which relies on the change in #72. Specs added for a simple single run, an autoWatch run where a bundled file changes, and an autoWatch run where a non-bundled file changes. Incorporates #72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52