Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plug-in): apply transforms and plugins on every rebuild #66

Closed
wants to merge 1 commit into from

Conversation

bendrucker
Copy link
Collaborator

So with browserify 7.0.1 manually resetting the bundle requires the transforms to be reapplied. Pretty sure the offending change is:

browserify/browserify@7.0.0...7.0.1#diff-168726dbe96b3ce427e7fedce31bb0bcL274

Not sure whether resetting is still necessary @nikku

@nikku
Copy link
Owner

nikku commented Dec 14, 2014

Browserifyyyyyyy ....

@bendrucker
Copy link
Collaborator Author

Lol. Possible a good time to change the prebundle behavior and move to configure and prebundle.

@nikku
Copy link
Owner

nikku commented Dec 16, 2014

Before we merge this and perform a major update we should look into #52, too.

@bendrucker
Copy link
Collaborator Author

Yeah definitely. The intent here was just to highlight the required change. Will probably ended up making more sense to cherry pick the commit onto a different branch with other changes.

@xdissent
Copy link
Contributor

Oh hi didn't see this... I just added a PR that fixes this problem. Browserify 7.0.1 had a weird bug that made the transform handling even weirder than 7.0.0 was supposed to make it. It's fixed in 7.0.2, but there's still a little funny business you have to pull to get it to behave the way we need it to: #68

@nikku
Copy link
Owner

nikku commented Dec 17, 2014

If both PRs solve the same issue, I'd go with this one. Browserify internals seem to change rather frequently so it might be safer to rely on the public API.

@nikku
Copy link
Owner

nikku commented Dec 17, 2014

I'll look into all the recent changes soon.

@xdissent
Copy link
Contributor

I feel ya, but I think re-instantiating a plugin/transform multiple times on the same bundler instance may cause more issues downstream. There's already a subtle difference in the way transforms and plugins are initialized depending on whether they're passed as options or added after the constructor is called (but the other PR makes up for this) so I'd tread lightly. The whole 7.0.0 thing really made stuff confusing, so yeah, no rush on any of this obviously.

@nikku
Copy link
Owner

nikku commented Dec 19, 2014

Using #68 as a solution.

@xdissent You are right about the reinstantiation problem. I don't want to get into that at all.

@nikku nikku closed this Dec 19, 2014
@bendrucker bendrucker deleted the b-7.0.1 branch December 20, 2014 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants