Update suo.rb to remove Dalli warning #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line removed was giving a warning message: `You can remove `require 'dalli/cas/client'` as this code has been rolled into the standard 'dalli/client'.`
|
Can someone approve this code change pretty please? |
langsharpe
added a commit
to langsharpe/dalli
that referenced
this pull request
Aug 4, 2022
Hi Team, I was wondering if you would consider removing this warning from dalli? We use dalli as a dependency of a dependency. The middle dependency is unlikely to be updated (The PR is here nickelser/suo#21). Would you consider removing this warning? As far as I can tell, there is no harm in leaving this file empty. I'm not asking you to be forever backwards compatible. Just to remove this one grain of sand from our development environment. Whatever you decide, thank you for maintaining this gem!
|
@nickelser can you review this PR please? |
|
@nickelser would be awesome to merge this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line removed was giving a warning message:
You can remove
require 'dalli/cas/client'as this code has been rolled into the standard 'dalli/client'.