Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting false-y values for cache_client #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielwestendorf
Copy link

Given an app that

  • Does not use this gem's disabled? functionality
  • Rails.cache is a file store

This gem then prepends every job execution with a file read. This isn't a big deal, but setting ActiveJob::TrafficControl.cache_client = false has no effect, despite the library having support for a false-y cache_client. This is due to usage of ||= and the default of Rails.cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant