Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cRIO FPGA and Hybrid Mode tests #207

Merged
merged 7 commits into from
Jun 23, 2022
Merged

Add cRIO FPGA and Hybrid Mode tests #207

merged 7 commits into from
Jun 23, 2022

Conversation

Karl-G1
Copy link
Contributor

@Karl-G1 Karl-G1 commented Apr 1, 2022

What does this Pull Request accomplish?

  • Add three new system tests for a cRIO 9045 and 3x 9401s:
    • Hybrid (2 FPGA slots and 1 Scan Mode)
    • FPGA (2 FPGA slots)
    • UDV (no C Series IO, only UDVs of various datatypes)
  • Add test assets for each test (FPGA VI and LabVIEW Project)

Workaround for Issue #211

When the new tests are run individually, they pass. When run sequentially, LabVIEW RT / VeriStand engine is prone to crashing, which results in various errors.
image

I filed issue #211 from this failure, and this PR works around the issue for now:

  • Add new sub VIs Deploy with Reboot and Retry.vi and Reboot Active Target.vi
  • When deploying, reboot the cRIO if the initial deployment fails
  • After all tests execute, call reboot from globalSetUp.vi

Why should this Pull Request be merged?

More fully test the ability for the custom device (and VeriStand) to support Combo cRIO targets.

What testing has been done?

Ran the tests against the ATS cRIO.
image

@niveristand-diff-bot

This comment was marked as outdated.

Copy link
Collaborator

@buckd buckd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Separate source for all FPGA Main VIs.
  • Update the build specs to output the correct bitfile names to the correct output location for all asset projects.

Test VIs look fine. I'm always torn on whether to use random data in tests, but in this instance, I think it's good.

@niveristand-diff-bot

This comment was marked as outdated.

Copy link
Collaborator

@buckd buckd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Bitfile names are pointing to the system definition file names.
    image
  • Destination should be pointing only to the Assets directory, not the Project/FPGA Bitfiles directory.

Copy link
Collaborator

@buckd buckd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending investigation into crashes.

@niveristand-diff-bot

This comment was marked as outdated.

@niveristand-diff-bot

This comment was marked as outdated.

@Karl-G1 Karl-G1 marked this pull request as ready for review June 21, 2022 19:02
@Karl-G1 Karl-G1 requested a review from rtzoeller as a code owner June 21, 2022 19:02
@niveristand-diff-bot

This comment was marked as outdated.

@niveristand-diff-bot
Copy link
Collaborator

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

cRIO System Tests.lvclass--Deploy with Reboot and Retry.vi.png

capture

cRIO System Tests.lvclass--globalTearDown.vi.png

capture

cRIO System Tests.lvclass--Reboot Active Target.vi.png

capture

cRIO System Tests.lvclass--setUp.vi.png

capture

cRIO System Tests.lvclass--tearDown.vi.png

capture

cRIO System Tests.lvclass--test FPGA DIO.vi.png

capture

cRIO System Tests.lvclass--test FPGA UDVs.vi.png

capture

cRIO System Tests.lvclass--test Hybrid DIO.vi.png

capture

FPGA Main.vi.png

capture

testExample 1.vi.png

capture

@Karl-G1 Karl-G1 merged commit 8dad96f into main Jun 23, 2022
@Karl-G1 Karl-G1 deleted the dev/add_crio_tests branch June 23, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants