-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radio group error #2423
Open
mollykreis
wants to merge
10
commits into
main
Choose a base branch
from
radio-group-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Radio group error #2423
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a773081
Implement error states on nimble-radio-group
mollykreis 5dfaf97
Update radio-group-matrix.stories.ts
mollykreis 8503595
Create radio-group.foundation.spec.ts
mollykreis dfb6d25
Change files
mollykreis 97fc13a
format
mollykreis cf3290e
Update radio-group-matrix.stories.ts
mollykreis d62f8ba
Merge branch 'main' into radio-group-error
mollykreis e472b67
simplify template declaration
mollykreis 189ee41
update errorVisibleDescription
mollykreis a34150a
Merge branch 'main' into radio-group-error
mollykreis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@ni-nimble-components-e5bfd621-8ece-4d9c-a6ea-eb128a70e8ac.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "minor", | ||
"comment": "Implement error states on nimble-radio-group", | ||
"packageName": "@ni/nimble-components", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import { elements, html, slotted } from '@microsoft/fast-element'; | ||
import { Orientation } from '@microsoft/fast-web-utilities'; | ||
import type { RadioGroup } from '.'; | ||
import { errorTextTemplate } from '../patterns/error/template'; | ||
import { iconExclamationMarkTag } from '../icons/exclamation-mark'; | ||
|
||
/* eslint-disable @typescript-eslint/indent */ | ||
export const template = html<RadioGroup>` | ||
<template | ||
role="radiogroup" | ||
aria-disabled="${x => x.disabled}" | ||
aria-readonly="${x => x.readOnly}" | ||
@click="${(x, c) => x.clickHandler(c.event as MouseEvent)}" | ||
@keydown="${(x, c) => x.keydownHandler(c.event as KeyboardEvent)}" | ||
@focusout="${(x, c) => x.focusOutHandler(c.event as FocusEvent)}" | ||
> | ||
<div class="label-container"> | ||
<slot name="label"></slot> | ||
<${iconExclamationMarkTag} | ||
severity="error" | ||
class="error-icon" | ||
></${iconExclamationMarkTag}> | ||
</div> | ||
<div | ||
class="positioning-region ${x => (x.orientation === Orientation.horizontal ? 'horizontal' : 'vertical')}" | ||
part="positioning-region" | ||
> | ||
<slot | ||
${slotted({ | ||
property: 'slottedRadioButtons', | ||
filter: elements('[role=radio]') | ||
})} | ||
></slot> | ||
${errorTextTemplate} | ||
</div> | ||
</template> | ||
`; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this introduces some spacing even when there is no label. I'm not sure how much we care about the no-label use case, but would it be better to apply the
margin-bottom
to::slotted([slot="label"]), .error-icon
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I debated this myself. The thing I didn't want to have happen, though, is for the control with no label to shift when
error-visible
was toggled, which is why I decide to leave the space there all the time.I'll leave the conversation open for others to weigh in.