Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tabindex overriding for Button, MenuButton, ToggleButton, Checkbox, and Anchor #2110

Merged
merged 19 commits into from
May 21, 2024
Merged

Support tabindex overriding for Button, MenuButton, ToggleButton, Checkbox, and Anchor #2110

merged 19 commits into from
May 21, 2024

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented May 15, 2024 •
edited
Loading

Pull Request

🤨 Rationale

Fixes #2094

👩‍💻 Implementation

For each of Button, MenuButton, ToggleButton, 'Checkbox', and Anchor, added tabindex attribute, updated the template to forward the tabindex value, and wrote automated tests. Additionally for Button and Checkbox, forked template from FAST and copied over the FAST tests.

🧪 Testing

Ran tests. Manually tested in Storybook in Chrome and Firefox.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc m-akinc requested a review from msmithNI May 15, 2024 19:30
@m-akinc
Copy link
Contributor Author

m-akinc commented May 15, 2024

@msmithNI Will you buddy this for me?

@m-akinc m-akinc changed the title Support tabindex overriding for Button, MenuButton, ToggleButton, and Anchor Support tabindex overriding for Button, MenuButton, ToggleButton, Checkbox, and Anchor May 15, 2024
@m-akinc m-akinc requested a review from msmithNI May 16, 2024 16:45
@m-akinc m-akinc marked this pull request as ready for review May 16, 2024 18:20
rajsite
rajsite reviewed May 20, 2024
View reviewed changes
Copy link
Member

@rajsite rajsite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the PR feedback applies to multiple spots but I did not comment on all of them. Make sure to address each instance of those issues.

@m-akinc m-akinc requested a review from rajsite May 20, 2024 23:42
@m-akinc m-akinc mentioned this pull request May 21, 2024
Open
@m-akinc m-akinc merged commit 32fcfaf into main May 21, 2024
11 checks passed
@m-akinc m-akinc deleted the users/makinc/tabindex-override branch May 21, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsite rajsite rajsite approved these changes

@jattasNI jattasNI jattasNI approved these changes

@msmithNI msmithNI msmithNI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need ability to override tabIndex on controls
4 participants
@m-akinc @rajsite @jattasNI @msmithNI