-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich text editor | Nimble listbox component bring up for mention popup #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-akinc
reviewed
Nov 7, 2023
packages/nimble-components/src/listbox/tests/listbox.stories.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/listbox/tests/listbox.stories.ts
Outdated
Show resolved
Hide resolved
change/@ni-nimble-components-46cd01a3-0093-40b0-94b4-d5773a0a0582.json
Outdated
Show resolved
Hide resolved
1 task
m-akinc
approved these changes
Nov 8, 2023
jattasNI
reviewed
Nov 8, 2023
jattasNI
approved these changes
Nov 9, 2023
rajsite
reviewed
Nov 9, 2023
3 tasks
rajsite
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
The
nimble-rich-text-mention-list-box
is the component used to populate the list of mention options in the editor. To enable some of the interactions within the popup, it requires FAST's listbox component. As the listbox has not been created in Nimble yet, this PR introduces a newnimble-listbox
component.For more details about mention list box component, see mention-hld.
👩💻 Implementation
nimble-listbox
component fromfast-listbox
Tests/
section in the storybook as it is not intended for end users usage and it is for the implementation ofnimble-rich-text-mention-list-box
for mention popup.menuMinWidth
token to share the min-width betweenmenu
andlistbox
🧪 Testing
nimble-listbox
component✅ Checklist