Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich text editor | Nimble listbox component bring up for mention popup #1654

Merged
merged 10 commits into from
Nov 11, 2023

Conversation

vivinkrishna-ni
Copy link
Contributor

@vivinkrishna-ni vivinkrishna-ni commented Nov 7, 2023

Pull Request

🤨 Rationale

The nimble-rich-text-mention-list-box is the component used to populate the list of mention options in the editor. To enable some of the interactions within the popup, it requires FAST's listbox component. As the listbox has not been created in Nimble yet, this PR introduces a new nimble-listbox component.

For more details about mention list box component, see mention-hld.

👩‍💻 Implementation

  1. Create a new nimble-listbox component from fast-listbox
  2. Add to the Tests/ section in the storybook as it is not intended for end users usage and it is for the implementation of nimble-rich-text-mention-list-box for mention popup.
  3. Create menuMinWidth token to share the min-width between menu and listbox

🧪 Testing

  1. Basic test cases are written for the new nimble-listbox component
  2. Storybook matrix test

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc m-akinc marked this pull request as ready for review November 8, 2023 16:33
@vivinkrishna-ni vivinkrishna-ni merged commit 176130f into main Nov 11, 2023
11 checks passed
@vivinkrishna-ni vivinkrishna-ni deleted the users/vivin/list-box branch November 11, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants