Rich Text Editor | Angular Integration for label provider in nimble-rich-text-editor #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/editor-globalization
suseendran-ni
approved these changes
Sep 1, 2023
m-akinc
approved these changes
Sep 1, 2023
...bel-provider/rich-text/tests/nimble-label-provider-rich-text-with-defaults.directive.spec.ts
Outdated
Show resolved
Hide resolved
vikisekarNI
reviewed
Sep 4, 2023
...ble-angular/label-provider/rich-text/tests/nimble-label-provider-rich-text.directive.spec.ts
Outdated
Show resolved
Hide resolved
vikisekarNI
approved these changes
Sep 5, 2023
|
Added @msmithNI who recently added the label infrastructure to quickly double check we didn't miss anything Angular specific |
rajsite
approved these changes
Sep 5, 2023
|
We can opt-out for approval from @atmgrifter00 since I'm pulling in malcom |
jattasNI
approved these changes
Sep 6, 2023
change/@ni-nimble-components-68c4b395-98d1-4e9b-bda3-ba58ff53d17c.json
Outdated
Show resolved
Hide resolved
msmithNI
approved these changes
Sep 6, 2023
rajsite
deleted the
users/aagash/editor-globalization-angular-integration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Issue Link : #1288
Angular Integration for the rich text component label providers to get localized from the client app when using the rich text component ( For now only
rich-text-editorhas labels ).👩💻 Implementation
Reference PR for implementation: #1360
This PR adds
NimbleLabelProviderRichTextDirectivein nimble-angular.🧪 Testing
✅ Checklist