Revamp rich text components folder structure #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivinkrishna-ni
changed the base branch from
main
to
users/vivin/editor-ui-api
vivinkrishna-ni
changed the base branch from
users/vivin/editor-ui-api
to
main
vivinkrishna-ni
changed the base branch from
main
to
users/vivin/editor-ui-api
vivinkrishna-ni
changed the base branch from
users/vivin/editor-ui-api
to
main
suseendran-ni
approved these changes
Sep 1, 2023
vivinkrishna-ni
commented
Sep 1, 2023
packages/nimble-components/src/rich-text/models/markdown-parser.ts
Outdated
Show resolved
Hide resolved
m-akinc
approved these changes
Sep 1, 2023
packages/nimble-components/src/rich-text/models/markdown-serializer.ts
Outdated
Show resolved
Hide resolved
...r-workspace/projects/ni/nimble-angular/rich-text-editor/nimble-rich-text-editor.directive.ts
Outdated
Show resolved
Hide resolved
…hub.com/ni/nimble into users/vivin/revamp-rich-text-components
vikisekarNI
approved these changes
Sep 4, 2023
packages/nimble-components/src/rich-text/viewer/specs/README.md
Outdated
Show resolved
Hide resolved
vivinkrishna-ni
requested review from
jattasNI,
atmgrifter00 and
mollykreis
as code owners
jattasNI
reviewed
Sep 5, 2023
packages/nimble-components/src/rich-text/models/markdown-parser.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Sep 5, 2023
angular-workspace/projects/ni/nimble-angular/rich-text/editor/ng-package.json
Outdated
Show resolved
Hide resolved
angular-workspace/projects/ni/nimble-angular/rich-text/editor/testing/ng-package.json
Outdated
Show resolved
Hide resolved
angular-workspace/projects/ni/nimble-angular/rich-text/viewer/ng-package.json
Outdated
Show resolved
Hide resolved
angular-workspace/projects/ni/nimble-angular/rich-text/viewer/testing/ng-package.json
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/rich-text/models/markdown-parser.ts
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Sep 6, 2023
rajsite
approved these changes
Sep 6, 2023
|
@vivinkrishna-ni looks like you have a merge conflict to resolve, once that is done feel free to merge. Don't need to wait on @atmgrifter00 or @mollykreis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Reorganize the folder structure of the
nimble-rich-text-editorandnimble-rich-text-viewerto share the common functionalities between components.Part of #1447
👩💻 Implementation
Revamped folder structure in nimble-components:
Revamped folder structure in nimble-angular:
Related discussion: #1424 (comment)
🧪 Testing
✅ Checklist