Angular support for nimble-rich-text-editor #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs/vivin/integrate-tiptap-editor
…rs/vivin/integrate-tiptap-editor
…rs/vivin/integrate-tiptap-editor
…rs/vivin/integrate-tiptap-editor
…rs/vivin/integrate-tiptap-editor
… into separate PRs
rajsite
approved these changes
Aug 29, 2023
...workspace/projects/ni/nimble-angular/rich-text-editor/testing/rich-text-editor.pageobject.ts
Outdated
Show resolved
Hide resolved
… the follow up PR.
1 task
…ub.com/ni/nimble into users/vivin/editor-angular-integration
rajsite
pushed a commit
that referenced
this pull request
Sep 6, 2023
# Pull Request ## 🤨 Rationale Issue Link : #1288 Currently, `rich-text-editor` has `title` and `text content` for formatting buttons (Bold, Italics, Bulleted List, Numbered List) and this needs to be localized from the client side. ## 👩💻 Implementation Reference PR for implementation: #1328 This PR creates label DesignTokens in `nimble-rich-text-editor` Note: Angular Integration will be taken up once after [this ](#1450 completion. ## 🧪 Testing - Verified that each label appears in the expected spots in the DOM for the affected components. Note that the current labels are mostly not user-visible. Future format button additions will introduce new visible label tokens. - Added autotests - For label providers: verify token naming, and that label provider attribute updates result in token updates - Updated [Storybook](https://60e89457a987cf003efc0a5b-ohnshtynly.chromatic.com/) - Rich Text Editor has a new "Localizable labels" row in their Storybook controls/API section - Under `Tokens/Label Providers` is a new `Rich Text Editor Label Provider`. ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: Aagash Raaj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
This PR includes Angular integration for the
nimble-rich-text-editorcomponent by exposing all the necessary APIs planned for the initial release. See the API section of the component spec.Part of #1288.
👩💻 Implementation
nimble-rich-text-editorto the example client appnimble-rich-text-editorandnimble-rich-text-viewer🧪 Testing
✅ Checklist