Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icons (bold, italic, and numbered list) and Chromatic config changes #1301

Merged
merged 8 commits into from
Jun 20, 2023

Conversation

jattasNI
Copy link
Contributor

@jattasNI jattasNI commented Jun 14, 2023

Pull Request

🀨 Rationale

Rick created these icons for #794 and reached out to me directly to integrate them into Nimble.

πŸ‘©β€πŸ’» Implementation

Followed the process in nimble-tokens CONTRIBUTING

  • the default icon names generated from Rick's file names seemed good enough to me. Font Awesome calls their "B" and "I" icons "bold" and "italic" too.
  • had to manually remove a fill from one of the icons so that severity colors would be applied. I asked Rick to make a similar change in Illustrator

Also noticed that the icon metadata file was only used for tests, so moved it to a tests location.

πŸ§ͺ Testing

Manual inspection of Storybook.

Chromatic didn't initially detect any icon changes because TurboSnap didn't notice that any dependencies of the icon story had changed. I added Chromatic externals configuration to the GitHub Actions configuration to include icon and token source files in their diff calculation, as described in Chromatic docs.

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@jattasNI jattasNI marked this pull request as ready for review June 14, 2023 16:44
@jattasNI jattasNI changed the title New icons for bold, italic, and numbered list New icons (bold, italic, and numbered list) and Chromatic config changes Jun 20, 2023
@jattasNI jattasNI enabled auto-merge (squash) June 20, 2023 13:45
@jattasNI jattasNI merged commit d8a2f69 into main Jun 20, 2023
@jattasNI jattasNI deleted the new-icons branch June 20, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants