New icons (bold, italic, and numbered list) and Chromatic config changes #1301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Rick created these icons for #794 and reached out to me directly to integrate them into Nimble.
π©βπ» Implementation
Followed the process in nimble-tokens CONTRIBUTING
Also noticed that the icon metadata file was only used for tests, so moved it to a tests location.
π§ͺ Testing
Manual inspection of Storybook.
Chromatic didn't initially detect any icon changes because TurboSnap didn't notice that any dependencies of the icon story had changed. I added Chromatic
externals
configuration to the GitHub Actions configuration to include icon and token source files in their diff calculation, as described in Chromatic docs.β Checklist