Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nimble Rich Text Editor and Viewer Spec Document #1289

Merged
merged 45 commits into from
Jun 27, 2023
Merged

Nimble Rich Text Editor and Viewer Spec Document #1289

merged 45 commits into from
Jun 27, 2023

Commits on Jun 8, 2023

  1. Initial nimble spec of the rich text editor and viewer component

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    f14ee94 View commit details
    Browse the repository at this point in the history

  2. Corrected the header name of the spec

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    8362d19 View commit details
    Browse the repository at this point in the history

  3. Change files

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    b22cbb7 View commit details
    Browse the repository at this point in the history

  4. Updated the supported features in feature section.

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    129dcf1 View commit details
    Browse the repository at this point in the history

  5. Resolved some of the PR comments

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    4e5ff60 View commit details
    Browse the repository at this point in the history

  6. Removed few methods as it is not required.

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    217e4f1 View commit details
    Browse the repository at this point in the history

  7. Resolve some of the PR comments

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    a95970b View commit details
    Browse the repository at this point in the history

  8. Updated the template for rich text editor

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    a26b2a4 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Resolved some of the PR comments and made update to some design changes.

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    d9abc1d View commit details
    Browse the repository at this point in the history

  2. Resolving PR comments on updating the doc on implementation and secur… 

    …ity section.
    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    acd0f22 View commit details
    Browse the repository at this point in the history

  3. Corrected the sentence in non goals section

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    7251bba View commit details
    Browse the repository at this point in the history

  4. Corrected the sentence in API section.

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    3e03f12 View commit details
    Browse the repository at this point in the history

  5. Spell check in the implementation part.

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    b8ed166 View commit details
    Browse the repository at this point in the history

  6. Sentence correction in accessability.

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    a11e16f View commit details
    Browse the repository at this point in the history

  7. Made few changes to doc as suggested

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    e9ea50d View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. noreply email update

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    3727587 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Resolved some of the PR comments in rich-text-editor and viewer spec

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    2e5c8c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Corrected minor changes.

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    afa0744 View commit details
    Browse the repository at this point in the history

  2. Updated the title of the viewer

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    6eb5829 View commit details
    Browse the repository at this point in the history

  3. Updated a point in the API events section

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    c831c23 View commit details
    Browse the repository at this point in the history

  4. Updated the spec images as per the new mockup screens

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    056e664 View commit details
    Browse the repository at this point in the history

  5. Added CSS design for both editor and viewer component

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    c2d64ba View commit details
    Browse the repository at this point in the history

  6. Resolved minor corrections in the spec

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    429d3b0 View commit details
    Browse the repository at this point in the history

  7. Updated the comments UI mockup link

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ecb1890 View commit details
    Browse the repository at this point in the history

  8. Corrected the risks and challenges points

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    455d8a6 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Updated the template and made few corrections in CSS design

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    ad6eca5 View commit details
    Browse the repository at this point in the history

  2. Updated the description in Non-goals section

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    35a9b5b View commit details
    Browse the repository at this point in the history

  3. Made few changes to the spec.

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    9aee11f View commit details
    Browse the repository at this point in the history

  4. Updated the API section for both the components

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    539b01d View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Resolved some of the corrections in the spec

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    c7a75d0 View commit details
    Browse the repository at this point in the history

  2. Resolved some of the PR comments

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    a09401f View commit details
    Browse the repository at this point in the history

  3. Updated the API to check the isEmpty value

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    1d86bf6 View commit details
    Browse the repository at this point in the history

  4. Updated the styling part of the component

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    f3d834d View commit details
    Browse the repository at this point in the history

  5. Updated the style information for viewer component.

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    f0049d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Updated the package size information to the dependencies

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    1651461 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Updated the spec as per the suggestion.

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    2490c80 View commit details
    Browse the repository at this point in the history

  2. Updated the spec

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    9c89946 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into rich-text-editor-viewer-spec

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    1a4191a View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Merge branch 'main' into rich-text-editor-viewer-spec

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    6cfd408 View commit details
    Browse the repository at this point in the history

  2. Updated the sizing changes for editor and viewer component.

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    92025d3 View commit details
    Browse the repository at this point in the history

  3. Resolved linting errors

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    d75a1a3 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Added information on the Angular implementation

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    bff8d5b View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Merge branch 'main' into rich-text-editor-viewer-spec

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    53841a7 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Updated the spec by removing the hyperlink support for the initial re… 

    …lease
    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    7007a3b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into rich-text-editor-viewer-spec

    @vivinkrishna-ni
    vivinkrishna-ni committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    4a10729 View commit details
    Browse the repository at this point in the history