Skip to content

Commit

Permalink
Dependency update September 2024 (#2413)
Browse files Browse the repository at this point in the history
# Pull Request

## 🤨 Rationale

A follow-up for #2410 and
#2408 which were getting in weird
states due to dependency updates around rollup.

## 👩‍💻 Implementation

Previously had found that the rollup-plugin-sourcemaps was [causing
issues](#2318 (comment))
because it had not been updated in a long time and resulted in a
transitive dependency on an old rollup version. This seems to mess with
rennovate updates.

- Updated to
[rollup-plugin-sourcemaps2](https://github.com/2wce/rollup-plugin-sourcemaps2)
which now seems to be [used in at least a few
projects](https://www.npmjs.com/package/rollup-plugin-sourcemaps2)
- Updated other dependencies that were pending
- Leveraged a new flag added to concurrently that causes the build logs
to align nicer by making prefixes the same width. Also has a bug fix
that handles stray new lines once in a while.
- Rebuilt the lockfile

## 🧪 Testing

- Verified manually that the bundled minified builds have working source
maps
- Rely on CI for rest of the updates
- Trigger full storybook build

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
  • Loading branch information
rajsite authored Sep 26, 2024
1 parent 78ca98b commit c17dc0b
Show file tree
Hide file tree
Showing 12 changed files with 2,217 additions and 3,992 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Dependency updates",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Dependency updates",
"packageName": "@ni/spright-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
6,160 changes: 2,186 additions & 3,974 deletions package-lock.json

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
"sync": "beachball sync",
"invoke-publish": "cross-env-shell beachball publish --yes --access public --message \\\"applying package updates [skip ci]\\\" -n $NPM_SECRET_TOKEN",
"performance": "npm run performance --workspaces --if-present",
"validate": "concurrently --timings --group \"npm:validate:*\"",
"validate": "concurrently --pad-prefix --timings --group \"npm:validate:*\"",
"validate:lint:sequential": "npm run lint --workspaces --if-present",
"validate:test:sequential": "npm run test --workspaces --if-present",
"validate:lint-concurrent:nimble-components": "npm run lint-concurrent -w packages/nimble-components",
"validate:test-concurrent:nimble-components": "npm run test-concurrent -w packages/nimble-components",
"test": "concurrently --timings --group \"npm:validate:test*\"",
"lint": "concurrently --timings --group \"npm:validate:lint*\"",
"test": "concurrently --pad-prefix --timings --group \"npm:validate:test*\"",
"lint": "concurrently --pad-prefix --timings --group \"npm:validate:lint*\"",
"storybook": "npm run start -w @ni-private/storybook"
},
"repository": {
Expand Down Expand Up @@ -57,7 +57,7 @@
],
"devDependencies": {
"beachball": "^2.45.0",
"concurrently": "^8.2.2",
"concurrently": "^9.0.0",
"cross-env": "^7.0.3",
"patch-package": "^8.0.0",
"playwright": "1.44.0"
Expand Down
1 change: 0 additions & 1 deletion packages/blazor-workspace/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"cross-env": "^7.0.3",
"glob": "^11.0.0",
"playwright": "1.44.0",
"rimraf": "^6.0.0",
"rollup": "^4.12.0"
}
}
12 changes: 6 additions & 6 deletions packages/nimble-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Styled web components for the NI Nimble Design System",
"scripts": {
"build": "npm run generate-icons && npm run generate-workers && npm run build-components && npm run bundle-components && npm run generate-scss",
"lint-concurrent": "concurrently --timings --group \"npm:eslint\" \"npm:prettier\"",
"lint-concurrent": "concurrently --pad-prefix --timings --group \"npm:eslint\" \"npm:prettier\"",
"format": "npm run prettier-fix",
"eslint": "eslint .",
"eslint-fix": "eslint . --fix",
Expand Down Expand Up @@ -41,7 +41,7 @@
"test-webkit:debugger": "karma start karma.conf.js --browsers=WebkitDebugging --skip-tags SkipWebkit",
"test-webkit:watch": "karma start karma.conf.headless.js --browsers=WebkitHeadless --skip-tags SkipWebkit --watch-extensions js",
"test-webkit": "karma start karma.conf.headless.js --browsers=WebkitHeadless --single-run --skip-tags SkipWebkit",
"test-concurrent": "concurrently --timings --group \"npm:test-chrome\" \"npm:test-firefox\" \"npm:test-webkit\""
"test-concurrent": "concurrently --pad-prefix --timings --group \"npm:test-chrome\" \"npm:test-firefox\" \"npm:test-webkit\""
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -103,14 +103,14 @@
"devDependencies": {
"@ni-private/eslint-config-nimble": "*",
"@ni/jasmine-parameterized": "^1.0.0",
"@rollup/plugin-commonjs": "^26.0.0",
"@rollup/plugin-commonjs": "^28.0.0",
"@rollup/plugin-node-resolve": "^15.0.1",
"@rollup/plugin-replace": "^5.0.1",
"@rollup/plugin-replace": "^6.0.0",
"@rollup/plugin-terser": "^0.4.0",
"@types/jasmine": "^5.1.4",
"@types/offscreencanvas": "^2019.7.3",
"@types/webpack-env": "^1.15.2",
"concurrently": "^8.2.2",
"concurrently": "^9.0.0",
"jasmine-core": "^5.1.2",
"karma": "^6.3.0",
"karma-chrome-launcher": "^3.1.0",
Expand All @@ -127,7 +127,7 @@
"prettier-eslint": "^16.3.0",
"prettier-eslint-cli": "^8.0.1",
"rollup": "^4.12.0",
"rollup-plugin-sourcemaps": "^0.6.3",
"rollup-plugin-sourcemaps2": "^0.4.1",
"source-map-loader": "^5.0.0",
"terser-webpack-plugin": "^5.3.10",
"typescript": "~5.4.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/nimble-components/rollup.config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import commonJS from '@rollup/plugin-commonjs';
import resolve from '@rollup/plugin-node-resolve';
import sourcemaps from 'rollup-plugin-sourcemaps';
import sourcemaps from 'rollup-plugin-sourcemaps2';
import terser from '@rollup/plugin-terser';
import replace from '@rollup/plugin-replace';

Expand Down
6 changes: 3 additions & 3 deletions packages/spright-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@
"devDependencies": {
"@ni/jasmine-parameterized": "^1.0.0",
"@ni-private/eslint-config-nimble": "*",
"@rollup/plugin-commonjs": "^26.0.0",
"@rollup/plugin-commonjs": "^28.0.0",
"@rollup/plugin-node-resolve": "^15.0.1",
"@rollup/plugin-replace": "^5.0.1",
"@rollup/plugin-replace": "^6.0.0",
"@rollup/plugin-terser": "^0.4.0",
"@types/jasmine": "^5.1.4",
"@types/webpack-env": "^1.15.2",
Expand All @@ -78,7 +78,7 @@
"prettier-eslint": "^16.3.0",
"prettier-eslint-cli": "^8.0.1",
"rollup": "^4.12.0",
"rollup-plugin-sourcemaps": "^0.6.3",
"rollup-plugin-sourcemaps2": "^0.4.1",
"source-map-loader": "^5.0.0",
"typescript": "~5.4.5",
"webpack": "^5.75.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/spright-components/rollup.config.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import commonJS from '@rollup/plugin-commonjs';
import resolve from '@rollup/plugin-node-resolve';
import sourcemaps from 'rollup-plugin-sourcemaps';
import sourcemaps from 'rollup-plugin-sourcemaps2';
import terser from '@rollup/plugin-terser';
import replace from '@rollup/plugin-replace';

Expand Down
2 changes: 1 addition & 1 deletion packages/storybook/.storybook/preview.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,5 +105,5 @@ configureActions({
depth: 1
});

// Update the GUID on this line to trigger a turbosnap full rebuild: 35fca962-ed23-4476-979e-094c9a0b48f3
// Update the GUID on this line to trigger a turbosnap full rebuild: 35fca962-ed23-4476-979e-094c9a0b48f4
// See https://www.chromatic.com/docs/turbosnap/#full-rebuilds
2 changes: 1 addition & 1 deletion packages/storybook/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"prettier-fix": "prettier-eslint \"**/*.*\" --write --prettier-ignore"
},
"devDependencies": {
"@chromatic-com/storybook": "^1.2.25",
"@chromatic-com/storybook": "^2.0.2",
"@microsoft/fast-element": "^1.12.0",
"@microsoft/fast-foundation": "^2.49.6",
"@microsoft/fast-react-wrapper": "^0.3.22",
Expand Down
File renamed without changes.

0 comments on commit c17dc0b

Please sign in to comment.