Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Add prosemirror-transform to @toast-ui/editor dependencies #3202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weaverryan
Copy link

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • [n/a] Tests for the changes have been added (for bug fixes/features)
  • [n/a] Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Hi!

Sorry if this PR is misguided. I noticed that the prosemirror-commands package is imported in several places - e.g. https://github.com/nhn/tui.editor/blob/master/apps/editor/src/wysiwyg/command/list.ts#L4 - but it was not listed under dependencies. We have a script that parses dependencies in package.json to do some dependency version checking for the Symfony PHP framework, which is how we stumped over this.

I used the latest version - but that could almost certainly be changed to a lower version, if desired.

Thanks!

This package is imported in several places, so it should be a dependency.
Copy link

@raonsol raonsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants