Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assistancewii: Add wiierror #1345

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

lifehackerhansol
Copy link
Collaborator

This leverages Wiimmfi's extensive error code database API to provide users a simple way to describe error codes displayed on the Wii and/or the Nintendo WFC.

Add needed init function for the AssistanceWii class to access the Kurisu bot object.

@ihaveamac
Copy link
Member

Should there be some kind of caching of responses? Especially if the information doesn't change often.

@lifehackerhansol
Copy link
Collaborator Author

Should there be some kind of caching of responses? Especially if the information doesn't change often.

I brought this up in helpers, but I think this is a good idea as well.

I just don't have the brain cells to touch the current database code to try and make that a reality.

@ihaveamac
Copy link
Member

An in-memory solution would probably work fine too, until it gets added to the database.

This leverages Wiimmfi's extensive error code database API to provide
users a simple way to describe error codes displayed on the Wii and/or
the Nintendo WFC.

Add needed __init__ function for the AssistanceWii class to access the
Kurisu bot object.
This cache will only be alive during runtime; it is not using the db.

It (hopefully) saves us from too many API calls.
@FrozenChen FrozenChen merged commit 99d749b into nh-server:main Sep 5, 2024
1 check passed
@lifehackerhansol lifehackerhansol deleted the wiimmfi-error branch September 5, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants