Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes from Coverity Report (12/01/2017) #66

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fixes from Coverity Report (12/01/2017) #66

wants to merge 7 commits into from
+24 −13

Commits on Dec 1, 2017

  1. Update nxt_conn_write.c 

    Fix Coverity report:
CID 200492 (nginx#1 of 1): Uninitialized scalar variable (UNINIT)2. uninit_use_in_call: Using uninitialized value sb.last when calling nxt_sendbuf_mem_coalesce. [show details]
    @RanierV
    RanierV committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    2ee3265 View commit details
    Browse the repository at this point in the history

  2. Update nxt_php_sapi.c 

    CID 200488 (nginx#1 of 2): Dereference null return value (NULL_RETURNS)11. dereference: Dereferencing a pointer that might be null run_ctx.mem_pool when calling nxt_mp_destroy.
    @RanierV
    RanierV committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    676ab95 View commit details
    Browse the repository at this point in the history

  3. Update nxt_time_parse.c 

    CID 200485 (nginx#1 of 1): Unused value (UNUSED_VALUE)assigned_value: Assigning value st_letter to state here, but that stored value is overwritten before it can be used.
    @RanierV
    RanierV committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    ec6cdeb View commit details
    Browse the repository at this point in the history

  4. Update nxt_socketpair.c 

    CID 200484 (nginx#1 of 1): Uninitialized scalar variable (UNINIT)2. uninit_use_in_call: Using uninitialized value msg. Field msg.msg_flags is uninitialized when calling recvmsg
    @RanierV
    RanierV committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    858cb4d View commit details
    Browse the repository at this point in the history

  5. Update nxt_process_title.c 

    CID 200480 (nginx#2 of 2): Resource leak (RESOURCE_LEAK)22. leaked_storage: Variable p going out of scope leaks the storage it points to.
    @RanierV
    RanierV committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    9173b78 View commit details
    Browse the repository at this point in the history

  6. Update nxt_linux_sendfile.c 

    CID 200475 (nginx#1 of 1): Uninitialized scalar variable (UNINIT)2. uninit_use_in_call: Using uninitialized value sb.last when calling nxt_sendbuf_mem_coalesce.
    @RanierV
    RanierV committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    a67463b View commit details
    Browse the repository at this point in the history

  7. Update nxt_event_conn_job_sendfile.c 

    CID 200471 (nginx#1 of 1): Uninitialized scalar variable (UNINIT)5. uninit_use_in_call: Using uninitialized value sb.last when calling nxt_sendbuf_mem_coalesce
    @RanierV
    RanierV committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    d28a21b View commit details
    Browse the repository at this point in the history