Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Modules #263

Merged
merged 11 commits into from
Oct 3, 2024
Merged

Update Modules #263

merged 11 commits into from
Oct 3, 2024

Conversation

apeltzer
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/demultiplex branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@apeltzer apeltzer requested review from nh13, sam-white04 and a team as code owners September 17, 2024 14:32
@apeltzer apeltzer requested review from kobelavaerts and removed request for a team September 17, 2024 14:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit b40ecc6

+| ✅ 190 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   7 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.5.1
  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-10-03 12:21:33

@apeltzer apeltzer requested review from atrigila and nschcolnicov and removed request for nh13, sam-white04 and kobelavaerts September 17, 2024 14:35
@nschcolnicov
Copy link
Contributor

nschcolnicov commented Sep 24, 2024 •
edited
Loading

Seems like after the new MultiQC version, it no longer raises an error but the MultiQC report is still not displaying the Kraken section. The old issue explaining this is MultiQC/MultiQC#2801 and was closed after releasing version 1.25.

I created a new issue to follow up on the missing kraken report: MultiQC/MultiQC#2876

MultiQC report not displaying kraken:
image

@nschcolnicov
Copy link
Contributor

I had to update some of the snaps, because the md5sums of some of the multiqc plots changed, due to them now displaying the numerical values with one decimal place:
image

nschcolnicov
nschcolnicov approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@nschcolnicov nschcolnicov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nschcolnicov nschcolnicov merged commit 3b2ef64 into dev Oct 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrigila atrigila atrigila approved these changes

@nschcolnicov nschcolnicov nschcolnicov approved these changes

@blajoie blajoie Awaiting requested review from blajoie blajoie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apeltzer @nschcolnicov @atrigila