Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Graal js language to support Java 22 #24

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: 🔧 Install java
uses: actions/setup-java@v1
with:
java-version: '11.0.7'
java-version: '17'

- name: 🔧 Install clojure
uses: DeLaGuardo/setup-clojure@master
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
- name: 🔧 Install java
uses: actions/setup-java@v1
with:
java-version: '11.0.7'
java-version: '17'

- name: 🔧 Install clojure
uses: DeLaGuardo/setup-clojure@master
Expand Down
13 changes: 12 additions & 1 deletion deps.edn
Original file line number Diff line number Diff line change
@@ -1,7 +1,18 @@
{:paths ["src" "resources"]
:deps {applied-science/js-interop {:mvn/version "0.3.3"}
org.clojure/data.json {:mvn/version "2.4.0"}
org.graalvm.js/js {:mvn/version "21.3.2.1"}}

;; recommended graal polyglot dependency setup as of graal JDK 23
;; https://www.graalvm.org/latest/reference-manual/embed-languages/#dependency-setup
;; (and example https://github.com/graalvm/polyglot-embedding-demo/blob/main/pom.xml)
;; 1) org.graalvm.polyglot/polyglot
;; 2) org.graalvm.polyglot/js
;; ---
;; 2) is a maven artifact of type 'pom' not supported by clojure deps, its pom points at
org.graalvm.js/js-language {:mvn/version "24.0.0"}
;; 1) is a dep of org.graalvm.js/js-language
}


:aliases
{:nextjournal/clerk
Expand Down
1 change: 0 additions & 1 deletion src/nextjournal/markdown.clj
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
;; matching the poliglot library versions specified in deps.edn
(.out System/out)
(.err System/err)
(.allowIO true)
(.allowExperimentalOptions true)
(.allowAllAccess true)
(.allowNativeAccess true)
Expand Down
Loading