feat(files_sharing): allow not deleting expiring shares #48225
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /** @var IAppManager */ | ||
| private $appManager; | ||
|
|
||
| /** @var IServerContainer */ |
Check notice
Code scanning / Psalm
DeprecatedInterface Note
| IGroupManager $groupManager, | ||
| IRootFolder $rootFolder, | ||
| IAppManager $appManager, | ||
| IServerContainer $serverContainer) { |
Check notice
Code scanning / Psalm
DeprecatedInterface Note
| 'id' => $share->getFullId(), | ||
| 'share_type' => $share->getShareType(), | ||
| 'uid_owner' => $share->getSharedBy(), | ||
| 'displayname_owner' => $this->userManager->get($share->getSharedBy())->getDisplayName(), |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
| 'expiration' => null, | ||
| 'token' => null, | ||
| 'uid_file_owner' => $share->getShareOwner(), | ||
| 'displayname_file_owner' => $this->userManager->get($share->getShareOwner())->getDisplayName(), |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
| if (!$node) { | ||
| // fallback to guessing the path | ||
| $node = $userFolder->get($share->getTarget()); | ||
| if ($node === null || $share->getTarget() === '') { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction Note
| */ | ||
| private function getRoomShareHelper() { | ||
| if (!$this->appManager->isEnabledForUser('spreed')) { | ||
| throw new QueryException(); |
Check notice
Code scanning / Psalm
DeprecatedClass Note
| */ | ||
| private function getDeckShareHelper() { | ||
| if (!$this->appManager->isEnabledForUser('deck')) { | ||
| throw new QueryException(); |
Check notice
Code scanning / Psalm
DeprecatedClass Note
| */ | ||
| private function getSciencemeshShareHelper() { | ||
| if (!$this->appManager->isEnabledForUser('sciencemesh')) { | ||
| throw new QueryException(); |
Check notice
Code scanning / Psalm
DeprecatedClass Note
| * @inheritdoc | ||
| */ | ||
| public function getExpiredShares($userId, $shareType, ?string $path = null, $limit = 50, $offset = 0) { | ||
| $shares = $this->getSharesBy($userId, $shareType, $path, false, $limit, $offset); |
Check failure
Code scanning / Psalm
InvalidArgument Error
Fix #17996
Feature
Shares that expires are just deleted. Which leads to confusion.
Solution
Status